Change in vdsm[master]: libvirt exception should be caught only in libvirtconnection
ybronhei at redhat.com
ybronhei at redhat.com
Wed May 1 09:14:18 UTC 2013
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirt exception should be caught only in libvirtconnection
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File lib/vdsm/libvirtconnection.py
Line 106: except:
Line 107: cif.log.error("Error running VM callback", exc_info=True)
Line 108:
Line 109:
Line 110: __connections = {}
What do you mean by passing the event sink?
Passing clientIF.getInstance() leads to a lot of import errors and make the code very dirty.
when do we need more connections anyway? why not to use always the same connection? i can omit the __connection dict, but before i need to understand the reason for that.. are there times that we do want to hold 2 different connections to libvirt?
Line 111: __connectionLock = threading.Lock()
Line 112:
Line 113:
Line 114: def setcif(cif):
--
To view, visit http://gerrit.ovirt.org/14345
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62db2a136c63dadf98ac9a330070b66a1925725
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list