Change in vdsm[master]: Stop spm if refresh fail on bad parameters.

abaron at redhat.com abaron at redhat.com
Wed May 1 07:08:31 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Stop spm if refresh fail on bad parameters.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 796:             pool.refresh(msdUUID, masterVersion)
Line 797:         except (se.StorageDomainAccessError, se.StorageDomainDoesNotExist,
Line 798:                 se.StoragePoolWrongMaster):
Line 799:             self.log.error("refreshStoragePool failed", exc_info=True)
Line 800:             pool.stopSpm()
this will throw a  not spm exception
Line 801:             self._disconnectPool(pool, pool.id, pool.scsiKey, False)
Line 802:             raise
Line 803: 
Line 804:         if pool.hsmMailer:


--
To view, visit http://gerrit.ovirt.org/13930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f85c3e731551b6974483cffe38c7ac37281370b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list