Change in vdsm[master]: libvirt exception should be caught only in libvirtconnection

danken at redhat.com danken at redhat.com
Wed May 1 04:28:41 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: libvirt exception should be caught only in libvirtconnection
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File lib/vdsm/libvirtconnection.py
Line 106:     except:
Line 107:         cif.log.error("Error running VM callback", exc_info=True)
Line 108: 
Line 109: 
Line 110: __connections = {}
Singletons are infectious. If you are to take this path, you do not need __connections at all.

How complex is the other approach, of passing the event sink to every get() call?
Line 111: __connectionLock = threading.Lock()
Line 112: 
Line 113: 
Line 114: def setcif(cif):


--
To view, visit http://gerrit.ovirt.org/14345
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62db2a136c63dadf98ac9a330070b66a1925725
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list