Change in vdsm[master]: Relink template hard links to meta and lease files

abaron at redhat.com abaron at redhat.com
Sun Mar 31 21:16:56 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Relink template hard links to meta and lease files
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/storage/fileSD.py
Line 543:                             volUUID + fileVolume.LEASE_FILEEXT]:
Line 544:                 tLink = os.path.join(basePath, rImg, volFile)
Line 545:                 tVol = os.path.join(basePath, templateImage, volFile)
Line 546:                 self.oop.fileUtils.safeUnlink(tLink)
Line 547:                 if self.hasVolumeLeases() or not volFile.contains(
this 'if' is confusing.  Instead I'd suggest something like:
files = [volUUID, volUUID + fileVolume.META_FILEEXT]
if self.hasVolumeLeases():
    files.append(volUUID + fileVolume.LEASE_FILEEXT)
for volFile in files:
...
Line 548:                         fileVolume.LEASE_FILEEXT):
Line 549:                     self.oop.os.link(tVol, tLink)
Line 550: 
Line 551: 


--
To view, visit http://gerrit.ovirt.org/12837
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idce0f3f1812fdf45efeeeffcccb7dc22b3b0d0f0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list