Change in vdsm[master]: Remove StoragePool.getImageDomainsList().

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Mar 31 05:24:02 UTC 2013


Eduardo has posted comments on this change.

Change subject: Remove StoragePool.getImageDomainsList().
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 3277:         vars.task.getSharedLock(STORAGE, spUUID)
Line 3278:         pool = self.getPool(spUUID)
Line 3279:         # Find out domain list from the pool metadata
Line 3280:         activeDoms = sorted(pool.getDomains(activeOnly=True).keys())
Line 3281:         foundIn = []
Done
Line 3282:         for sdUUID in activeDoms:
Line 3283:             try:
Line 3284:                 imgs = self.getImagesList(sdUUID)
Line 3285:             except se.StorageDomainDoesNotExist:


Line 3280:         activeDoms = sorted(pool.getDomains(activeOnly=True).keys())
Line 3281:         foundIn = []
Line 3282:         for sdUUID in activeDoms:
Line 3283:             try:
Line 3284:                 imgs = self.getImagesList(sdUUID)
The point is removing redundant code and unify the criteria for partially removed images.
Line 3285:             except se.StorageDomainDoesNotExist:
Line 3286:                 self.log.error("domain %s can't be reached.", exc_info=True)
Line 3287:             else:
Line 3288:                 if imgUUID in imgs:


--
To view, visit http://gerrit.ovirt.org/12927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I225fa7a58e1fabb844cc883938e94df39d2a8ae2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list