Change in vdsm[master]: getAllTasksList\Status with spUUID retrieves info only if ho...

danken at redhat.com danken at redhat.com
Thu Mar 28 14:42:36 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2035:         taskStatus = self.taskMng.getTaskStatus(taskID=taskID)
Line 2036:         return dict(taskStatus=taskStatus)
Line 2037: 
Line 2038:     @public
Line 2039:     def getAllTasksStatuses(self, spUUID=None):
Why was "options=None" dropped from the function's signature?
I do not see how this is related to the purpose of this patch.

It may well be that we need to drop it - and we may even be able to do it since no Engine ever used it - but adding it to this disputed patch only complicates things for me.
Line 2040:         """
Line 2041:         Gets the status of all public tasks.
Line 2042: 
Line 2043:         :param spUUID: if specified returns pool specific tasks,


--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list