Change in vdsm[master]: vm: update volume apparentsize after snapshot

fsimonce at redhat.com fsimonce at redhat.com
Tue Mar 26 18:04:17 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: vm: update volume apparentsize after snapshot
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 2070:         # is to prevent spurious libvirt errors about missing drive paths
Line 2071:         # (since we're changing them), and also to prevent to trigger a drive
Line 2072:         # extension for the new volume with the apparent size of the old one
Line 2073:         # (the apparentsize is updated as last step in updateDriveParameters)
Line 2074:         self.stopDisksStatsCollection()
This probably needs to be moved inside the while loop (line ~2084) since the finally clause will restart the disk stats when the snapshot with quiesce failed.
Line 2075: 
Line 2076:         snapFlags = (libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY |
Line 2077:                      libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT |
Line 2078:                      libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA)


--
To view, visit http://gerrit.ovirt.org/13346
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I472c2931551643914e6a09b54d3d96f371f34864
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list