Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

danken at redhat.com danken at redhat.com
Sun Mar 24 19:37:55 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field
......................................................................


Patch Set 6:

Well, I still have reservations against requiring the explicit bridged=True for bridges.

Something more complex is that I have a feeling that Engine already rely of cfg. We should be cautious if want to make it optional.

--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list