Change in vdsm[master]: Optimize netinfo.networks.

danken at redhat.com danken at redhat.com
Sun Mar 24 11:41:39 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Optimize netinfo.networks.
......................................................................


Patch Set 3: Looks good to me, approved

(1 inline comment)

....................................................
File lib/vdsm/netinfo.py
Line 94:     for net, netname in allNets:
Line 95:         if netname.startswith(LIBVIRT_NET_PREFIX):
Line 96:             netname = netname[len(LIBVIRT_NET_PREFIX):]
Line 97:         else:
Line 98:             continue
I'm not sure I like the use of "continue" over the original code, but I do not care enough to interfere with your patch.
Line 99:         nets[netname] = {}
Line 100:         xml = minidom.parseString(net.XMLDesc(0))
Line 101:         interfaces = xml.getElementsByTagName('interface')
Line 102:         if len(interfaces) > 0:


--
To view, visit http://gerrit.ovirt.org/13159
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cd332819363c4399335358686e19d6a1dc3b45e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list