Change in vdsm[master]: configNetworks: network info gathering to netinfo

danken at redhat.com danken at redhat.com
Thu Mar 21 20:06:54 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: configNetworks: network info gathering to netinfo
......................................................................


Patch Set 5: Looks good to me, approved

(1 inline comment)

makes sense, and provide a little bit of optimization.

....................................................
File vdsm/configNetwork.py
Line 1032: 
Line 1033: def _removeUnusedNics(network, vlan, bonding, nics, configWriter):
Line 1034:     _netinfo = netinfo.NetInfo()
Line 1035:     for nic in nics:
Line 1036:         if not _netinfo.nicOtherUsers(network, vlan, bonding, nic):
nice. no need to create NetInfo() len(nics) times.
Line 1037:             ifdown(nic)
Line 1038:             configWriter.removeNic(nic)
Line 1039:             ifup(nic)
Line 1040: 


--
To view, visit http://gerrit.ovirt.org/13171
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34a07f0ea33407a566bcc9c82e5ba6ca0c0701a6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list