Change in vdsm[master]: vdsm: propagate MountError when mount fails

abaron at redhat.com abaron at redhat.com
Thu Mar 21 15:43:09 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: vdsm: propagate MountError when mount fails
......................................................................


Patch Set 6: (2 inline comments)

....................................................
File vdsm/storage/storageServer.py
Line 213:                            exc_info=True)
Line 214:             try:
Line 215:                 os.rmdir(self._getLocalPath())
Line 216:             except OSError:
Line 217:                 pass
failing to delete a directory 99% of the cases would just mean that we do not have permissions to delete it.  Since 'mount' is run as root then most likely there is no connection between this failure and mount failure.
Although I agree about logging here, this is no way a severe programming issue.
Line 218:             #We raise the MountError here since this is the real issue and not
Line 219:             #the minor rmdir success.
Line 220:             raise e
Line 221: 


Line 218:             #We raise the MountError here since this is the real issue and not
Line 219:             #the minor rmdir success.
Line 220:             raise e
Line 221: 
Line 222:         try:
Besides the fact that it's redundant like adding an else to the first 'if' in this function, in this case it might also mask errors (reaching end of function successfully when we should be failing).
Line 223:             fileSD.validateDirAccess(self.getMountObj().getRecord().fs_file)
Line 224:         except se.StorageServerAccessPermissionError:
Line 225:             try:
Line 226:                 self.disconnect()


--
To view, visit http://gerrit.ovirt.org/10966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list