Change in vdsm[master]: SetupNetworks: remove redundant logging.

danken at redhat.com danken at redhat.com
Thu Mar 21 14:00:08 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: SetupNetworks: remove redundant logging.
......................................................................


SetupNetworks: remove redundant logging.

Most of setupNetworks was wrapped in a try catch the sole purpose
of which was to log any error that could happen. This is not
necessary anymore due to the fact that supervdsm.py (caller of
setupNetworks) has its setupNetworks call under logDecorator
which achieves the original purpose in a more generic way.

Change-Id: Ifd1c3ef1bd936de56934b2a474b6b5fb829868c0
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M vdsm/configNetwork.py
1 file changed, 67 insertions(+), 74 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd1c3ef1bd936de56934b2a474b6b5fb829868c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list