Change in vdsm[master]: vdsm: Try to reconnect on vmchannel after errors

danken at redhat.com danken at redhat.com
Thu Mar 21 10:53:55 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Try to reconnect on vmchannel after errors
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File vdsm/guestIF.py
Line 98:             self._sock.close()
Line 99:         self._sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
Line 100:         self._sock.setblocking(0)
Line 101:         # Save the socket's fileno because a call to fileno() fails if the
Line 102:         # socket is closed before GuestAgent.stop() is called.
do we really want to keep a stale fd of a closed socket?

when we get to use it, it may point to an unrelated file or socket.
Line 103:         self._sock_fd = self._sock.fileno()
Line 104:         return self._sock_fd
Line 105: 
Line 106:     @staticmethod


--
To view, visit http://gerrit.ovirt.org/11977
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b9418e39558d45c97e9545bc9ecc4935f004e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Jason Dillaman <jdillama at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list