Change in vdsm[master]: Remove unused onlyDataDomains parameter from getImageDomains...

ykaplan at redhat.com ykaplan at redhat.com
Wed Mar 20 10:13:24 UTC 2013


Yeela Kaplan has posted comments on this change.

Change subject: Remove unused onlyDataDomains parameter from getImageDomainsList.
......................................................................


Patch Set 5: (2 inline comments)

....................................................
Commit Message
Line 5: CommitDate: 2013-03-18 08:05:28 +0200
Line 6: 
Line 7: Remove unused onlyDataDomains parameter from getImageDomainsList.
Line 8: 
Line 9: (Required for next patch.)
What is next patch? please explain the motivation. It is difficult to review this way.
Line 10: 
Line 11: Change-Id: I25fe2714e4c4e832230653cebc87d8da0e81028b


....................................................
File vdsm/storage/sp.py
Line 1669
Line 1670
Line 1671
Line 1672
Line 1673
Please explain why is this not necessary


--
To view, visit http://gerrit.ovirt.org/12926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25fe2714e4c4e832230653cebc87d8da0e81028b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list