Change in vdsm[master]: dsaversion: Adding software_release

danken at redhat.com danken at redhat.com
Tue Mar 19 15:45:45 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: dsaversion: Adding software_release
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/dsaversion.py.in
Line 26: # FIXME: As soon as we can provide a long version/release to oVirt-Engine
Line 27: #        remove from vdsm.spec the sed to replace the below macros
Line 28: software_version = "@PACKAGE_VERSION@"
Line 29: software_revision = "@PACKAGE_RELEASE@"
Line 30: software_release = "@PACKAGE_VERSION at .@PACKAGE_RELEASE@"
sorry, I still dislike the name. it's not just the release. it's version AND release. "rpmVR" may be more exact.
Line 31: 
Line 32: version_info = {
Line 33:     'version_name': version_name,
Line 34:     'software_version': software_version,


--
To view, visit http://gerrit.ovirt.org/12952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44b6a28e378c4090595e823588dbbe583a38a353
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list