Change in vdsm[master]: vdsm: Add additional exception handling within vmChannels.py
danken at redhat.com
danken at redhat.com
Mon Mar 18 21:49:16 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Add additional exception handling within vmChannels.py
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/vmChannels.py
Line 132: def run(self):
Line 133: """ The listener thread's function. """
Line 134: self.log.info("Starting VM channels listener thread.")
Line 135: self._quit = False
Line 136: try:
Federico, which exception do you expect to handle within the loop? We must add the logging in run() since it's rule#1 of how to write a thread in Python, but I do not think we should assume that another attempt would automatically solve a caught exception.
Vinzenz, If you think otherwise, you would have to introduce a sleep(1) after exception to avoid a tight loop. In any case, that's a different discussion that should be done in another patch.
Line 137: while not self._quit:
Line 138: self._wait_for_events()
Line 139: except:
Line 140: self.log.exception("Unhandled exception caught in vm channels "
--
To view, visit http://gerrit.ovirt.org/13093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie733ca7ccd2689f6041ee18bbe335f355a89ac55
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Jason Dillaman <jdillama at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list