Change in vdsm[master]: vdsm: propagate MountError when mount fails

vvolansk at redhat.com vvolansk at redhat.com
Mon Mar 18 16:20:00 UTC 2013


Vered Volansky has posted comments on this change.

Change subject: vdsm: propagate MountError when mount fails
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/storage/storageServer.py
Line 205:         except OSError as e:
Line 206:             if e.errno != errno.EEXIST:
Line 207:                 raise
Line 208: 
Line 209:         try:
I see what you mean, but I don't see a clash between the two. The other patch is not sufficient because the MountError will not be propagated to the engine, so the bug will not be solved unless this patch is enclosed at least in the other. I also think that since the two don't clash and there's a working solution it should also be merged, unless it's nacked on it's own merrits.
Line 210:             self._mount.mount(self.options, self._vfsType)
Line 211:         except MountError as e:
Line 212:             try:
Line 213:                 os.rmdir(self._getLocalPath())


--
To view, visit http://gerrit.ovirt.org/10966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list