Change in vdsm[master]: Encode '=' when persisting the Task.

danken at redhat.com danken at redhat.com
Mon Mar 18 12:51:14 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Encode '=' when persisting the Task.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/task.py
Line 80: ROLLBACK_SENTINEL = "rollback sentinel"
Line 81: 
Line 82: 
Line 83: def _eq_encode(s):
Line 84:     return s.replace(KEY_SEPARATOR, KEY_SEPARATOR_ENCODED)
this encoding is not reversible.

 STR = 'hellow _eq_ world'
 _eq_decode(_eq_encode(STR)) != STR
Line 85: 
Line 86: 
Line 87: def _eq_decode(s):
Line 88:     return s.replace(KEY_SEPARATOR_ENCODED, KEY_SEPARATOR)


--
To view, visit http://gerrit.ovirt.org/13128
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I735d28974d3953aafaf4b5e5f1a25363d22b50c3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list