Change in vdsm[master]: vdsm: Catch OSError in _translateConnectionError

ewarszaw at redhat.com ewarszaw at redhat.com
Mon Mar 18 08:15:32 UTC 2013


Eduardo has posted comments on this change.

Change subject: vdsm: Catch OSError in _translateConnectionError
......................................................................


Patch Set 3:

As stated in:
https://bugzilla.redhat.com/show_bug.cgi?id=883877#c10
mount.py is raising OSError when fails it fails to find the dst directory that just succeed to remove, after a failed mount. 
The mount error is catched and swallowed and verify is called immediately. 
Applying something in the spirit of:
http://gerrit.ovirt.org/#/c/12042/
makes mount.py raise the correct MountError for errors during mount, making this change redundant.

If OSErrors occurs in mount, there is nothing much to do
in higher levels of vdsm. It may be due to mount point
being created/deleted by other thread or another _strange Thing_ that is probably a programming error.

I thing that is worth to distinguish between the failed mount that is something for the user to fix (permissions, existence of the mount, etc.) and errors during the manipulation of the mount point.

--
To view, visit http://gerrit.ovirt.org/10966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list