Change in vdsm[master]: Ignore partially deleted images in getAllImages().

abaron at redhat.com abaron at redhat.com
Sun Mar 17 12:05:41 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Ignore partially deleted images in getAllImages().
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 923:                     mdathreshold=vgMetadataStatus['mdathreshold'])
Line 924: 
Line 925:     def getAllImages(self):
Line 926:         """
Line 927:         Get the set of all images uuids in the SD.
will this cause getAllImages in vdsClient to not display broken images?
I wonder if we shouldn't change the interface and actually display those in a clear fashion.  Alternatively, expose a new verb in vdsClient to retrieve the partial images.
Line 928:         """
Line 929:         vols = self.getAllVolumes()  # {volName: ([imgs], parent)}
Line 930:         images = set()
Line 931:         for imgs, parent in vols.itervalues():


--
To view, visit http://gerrit.ovirt.org/12938
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028dabbf1a0b39177d0c52222cae177f5123442f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list