Change in vdsm[master]: Prefetch domains when connecting a storage server.

fsimonce at redhat.com fsimonce at redhat.com
Thu Mar 14 18:37:03 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: Prefetch domains when connecting a storage server.
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sdc.py
Line 131:                 self._syncroot.notifyAll()
Line 132: 
Line 133:     def _findDomain(self, sdUUID):
Line 134:         try:
Line 135:             findMethod = self.knownSDs[sdUUID]
we also need to find a way to clean the dictionary when possible, I don't like the idea of a collection that can grow without a bound.
Line 136:         except KeyError:
Line 137:             self.log.error("looking for unfetched domain %s", sdUUID)
Line 138:             return self._findUnfetchedDomain(sdUUID)
Line 139:         else:


--
To view, visit http://gerrit.ovirt.org/12869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f2b19a566c659bac30a318d17cef929e0b2575b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list