Change in vdsm[master]: Migration warning due to high guest memory changes
danken at redhat.com
danken at redhat.com
Wed Mar 13 21:36:22 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: Migration warning due to high guest memory changes
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 414: self.stop()
Line 415: break
Line 416:
Line 417: if dataRemaining > smallest_dataRemaining:
Line 418: MB = 1024 * 1024
strictly speaking, it's MiB.
Line 419: self._vm.log.warn(
Line 420: 'Migration stalling: dataRemaining (%sMB)'
Line 421: ' is more than smallest_dataRemaining (%sMB).'
Line 422: ' Reduce guest load or consider increasing the value of'
Line 418: MB = 1024 * 1024
Line 419: self._vm.log.warn(
Line 420: 'Migration stalling: dataRemaining (%sMB)'
Line 421: ' is more than smallest_dataRemaining (%sMB).'
Line 422: ' Reduce guest load or consider increasing the value of'
This long line is going to show up every _MIGRATION_MONITOR_INTERVAL (in some bad cases). Wouldn't it be better to point people to the BZ instead? I also prefer ">" over "is more than".
Line 423: ' migration_downtime if migration get stuck.' %
Line 424: (dataRemaining / MB, smallest_dataRemaining / MB))
Line 425:
Line 426: if jobType == 0:
--
To view, visit http://gerrit.ovirt.org/12557
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e7c5a2b7e9e97f047fa893a47408a659a40beb2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list