Change in vdsm[master]: Remove hbtl attribute of non-scsi devices
ykaplan at redhat.com
ykaplan at redhat.com
Wed Mar 13 13:50:23 UTC 2013
Yeela Kaplan has posted comments on this change.
Change subject: Remove hbtl attribute of non-scsi devices
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File vdsm/storage/multipath.py
Line 326: try:
Line 327: hbtl = getHBTL(slave)
Line 328: except OSError as e:
Line 329: if e.errno == errno.ENOENT:
Line 330: log.warn("Device has no hbtl: %s", slave, exc_info=True)
Done
Line 331: else:
Line 332: log.error("Error while trying to get hbtl of device: %s",
Line 333: slave, exc_info=True)
Line 334: raise
Line 329: if e.errno == errno.ENOENT:
Line 330: log.warn("Device has no hbtl: %s", slave, exc_info=True)
Line 331: else:
Line 332: log.error("Error while trying to get hbtl of device: %s",
Line 333: slave, exc_info=True)
Done
Line 334: raise
Line 335: else:
Line 336: pathInfo["lun"] = hbtl.lun
Line 337:
Line 374: devInfo["devtype"] == DEV_MIXED
Line 375:
Line 376: devInfo["paths"].append(pathInfo)
Line 377:
Line 378: yield devInfo
True. You can see with git grep.
Line 379:
Line 380:
Line 381: TOXIC_REGEX = re.compile(r"[%s]" % re.sub(r"[\-\\\]]",
Line 382: lambda m: "\\" + m.group(),
--
To view, visit http://gerrit.ovirt.org/12999
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie94e5703b48ffc22fe8bda427d364faae4f7c256
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list