Change in vdsm[master]: Prefetch domains when connecting a storage server.

ewarszaw at redhat.com ewarszaw at redhat.com
Tue Mar 12 12:29:21 UTC 2013


Eduardo has posted comments on this change.

Change subject: Prefetch domains when connecting a storage server.
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 2238:     def __prefetchDomains(self, domType, conObj):
Line 2239:         uuidPatern = "????????-????-????-????-????????????"
Line 2240: 
Line 2241:         if domType in (sd.FCP_DOMAIN, sd.ISCSI_DOMAIN):
Line 2242:             uuids = blockSD.getStorageDomainsList()
The two are iterables.
Line 2243:             self.log.debug("block uuids: %s", uuids)
Line 2244:         elif domType in (sd.NFS_DOMAIN, sd.POSIXFS_DOMAIN):
Line 2245:             lPath = conObj._mountCon._getLocalPath()
Line 2246:             self.log.debug("nfs lpath: %s", lPath)


Line 2249:             self.log.debug("nfs uuids: %s", uuids)
Line 2250:         elif domType is sd.GLUSTERFS_DOMAIN:
Line 2251:             glusterDomPath = os.path.join(sd.GLUSTERSD_DIR, "*")
Line 2252:             uuids = tuple(sdUUID for sdUUID, domainPath in
Line 2253:                           nfsSD.fileSD.scanDomains(glusterDomPath))
Unintentional
Line 2254:         elif domType is sd.LOCALFS_DOMAIN:
Line 2255:             lPath = conObj._path
Line 2256:             self.log.debug("local lpath: %s", lPath)
Line 2257:             uuids = tuple(os.path.basename(d) for d in


....................................................
File vdsm/storage/sdc.py
Line 150:         import glusterSD
Line 151:         import localFsSD
Line 152:         import nfsSD
Line 153: 
Line 154:         self.log.error("looking for domain %s", sdUUID)
Because this method is a fall back an should be used only if a new domain was added without the proper connect. This is mainly for the BlockSD case.
Receiving a new connect will update the SDs in this connection.
Line 155: 
Line 156:         # The order is somewhat important, it's ordered
Line 157:         # by how quickly get can find the domain. For instance
Line 158:         # if an nfs mount is unavailable we will get stuck


--
To view, visit http://gerrit.ovirt.org/12869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f2b19a566c659bac30a318d17cef929e0b2575b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list