Change in vdsm[master]: Fix checking bonding options for missing bonds.

danken at redhat.com danken at redhat.com
Tue Mar 12 08:09:52 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix checking bonding options for missing bonds.
......................................................................


Fix checking bonding options for missing bonds.

Right up until now, we were checking the options for a bond A
that would have to be potentially created by checking for the
existance of /sys/class/net/A/bonding/<opt>. Obviously, if the
bond had not been created at that point, the option validation
would fail.

This patch makes the option validation be done on whichever bond
is present on the system and, if none are, it creates the bond
to check the options.

Change-Id: I023a5bb8a52719559bb9d4716f25e0cba8b3530b
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Bug-Url: https://bugzilla.redhat.com/918666
---
M vdsm/configNetwork.py
1 file changed, 30 insertions(+), 12 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I023a5bb8a52719559bb9d4716f25e0cba8b3530b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list