Change in vdsm[master]: trival change for skip mom test logic
wudxw at linux.vnet.ibm.com
wudxw at linux.vnet.ibm.com
Fri Mar 8 08:04:51 UTC 2013
Mark Wu has posted comments on this change.
Change subject: trival change for skip mom test logic
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File tests/functional/momTests.py
Line 31: @wraps(method)
Line 32: def wrapped(self, *args, **kwargs):
Line 33: r = self.s.getVdsCapabilities()
Line 34: self.assertEquals(r['status']['code'], 0)
Line 35: if not r['info']['packages2'].get('mom'):
the test will be skipped if mom is installed from source code. So it could cause mom developer can't run this test.
Line 36: raise SkipTest('MOM is not installed')
Line 37: return method(self, *args, **kwargs)
Line 38: return wrapped
Line 39:
Line 42: def setUp(self):
Line 43: self.s = vdscli.connect()
Line 44:
Line 45: @skipNoMOM
Line 46: @testValidation.ValidateRunningAsRoot
Yes, it's to avoid secure connection failure
Line 47: def testKSM(self):
Line 48: run = 1
Line 49: pages_to_scan = random.randint(100, 200)
Line 50:
--
To view, visit http://gerrit.ovirt.org/12550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee2adb63d61f708d74ef84ee68f220994247eea3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list