Change in vdsm[master]: Makefile.am: ignore false positive pyflakes lvm.py

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Fri Mar 8 06:35:56 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: Makefile.am: ignore false positive pyflakes lvm.py
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File Makefile.am
Line 71: check-local:
Line 72: 	find . -path './.git' -prune -type f -o \
Line 73: 		-name '*.py' -o -name '*.py.in'  | xargs $(PYFLAKES) |\
Line 74: 		xargs -r || xargs -I {} bash -c \
Line 75: 		'if grep $(SKIP_PYFLAKES_ERR) {} ; then continue {} ; fi'
I would like to propose

SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \
	'lv' from line .*"

check-local:
	find . -path './.git' -prune -type f -o \
		-name '*.py' -o -name '*.py.in'  | xargs $(PYFLAKES) | \
		grep -w -v $(SKIP_PYFLAKES_ERR) | \
		while read LINE; do echo "$$LINE"; false; done
Line 76: 	$(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in' \
Line 77: 		$(PEP8_WHITELIST)
Line 78: 	@if test -f .gitignore; then \
Line 79: 	  for i in `git ls-files \*.in`; do \


--
To view, visit http://gerrit.ovirt.org/12700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cdeb0c28c1ee5dc3a18a7688ae60fe641f9a6c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list