Change in vdsm[master]: vdsm: create /etc/modules-load.d/vdsm.conf

danken at redhat.com danken at redhat.com
Thu Mar 7 14:52:25 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: create /etc/modules-load.d/vdsm.conf
......................................................................


Patch Set 12: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm.spec.in
Line 855: %{python_sitearch}/%{vdsm_name}/betterPopen/__init__.py*
Line 856: %{python_sitearch}/%{vdsm_name}/betterPopen/createprocess.so
Line 857: %{python_sitearch}/%{vdsm_name}/tool/__init__.py*
Line 858: %if 0%{?with_systemd}
Line 859: %exclude %{python_sitearch}/%{vdsm_name}/tool/load_needed_modules.py*
I believe that you are still call this module from vdsmd start. I suppose you should skip

 /usr/bin/vdsm-tool load-needed-modules

if it's systemd.
Line 860: %else
Line 861: %{python_sitearch}/%{vdsm_name}/tool/load_needed_modules.py*
Line 862: %endif
Line 863: %{python_sitearch}/%{vdsm_name}/tool/passwd.py*


--
To view, visit http://gerrit.ovirt.org/11718
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I026ff658482ccefbdcc384785cdec10cf934b7d9
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list