Change in vdsm[master]: gluster: Handling Attribute error in Python 2.6

avishwan at redhat.com avishwan at redhat.com
Wed Mar 6 09:42:28 UTC 2013


Aravinda VK has posted comments on this change.

Change subject: gluster: Handling Attribute error in Python 2.6
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/gluster/cli.py
Line 84:     try:
Line 85:         tree = etree.fromstring('\n'.join(out))
Line 86:         rv = int(tree.find('opRet').text)
Line 87:         msg = tree.find('opErrstr').text
Line 88:     except:
SyntaxError is not replacement for etree.ParseError. SyntaxError will be raised only when eval/input is called.
Line 89:         raise ge.GlusterXmlErrorException(err=out)
Line 90:     if rv == 0:
Line 91:         return tree
Line 92:     else:


--
To view, visit http://gerrit.ovirt.org/12752
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63c33b34ce11473636365ea094e267c5424c7255
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list