Change in vdsm[master]: getAllTasksList\Status with 'spm_tasks' option retrieves in...

ybronhei at redhat.com ybronhei at redhat.com
Tue Mar 5 11:24:11 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: getAllTasksList\Status with 'spm_tasks' option  retrieves info only if host SPM
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 310:             raise se.IsSpm(spUUID)
Line 311: 
Line 312:     @classmethod
Line 313:     def getPool(cls, spUUID):
Line 314:         # If passed None, return first pool
You told me to do it that way.. You told me to call getPool without specific UUID and change it to return the only pool because thats how it works currently (only one pool can possibly be connected). 
The engine won't pass the UUID as you commented on the last patchset, engine will pass only option val that get spm_tasks. so I don't understand what you're suggesting? are you suggesting something else or just saying that we can't do it in any way?
Line 315:         if spUUID is None:
Line 316:             try:
Line 317:                 return cls.pools.popitem()
Line 318:             except KeyError:


--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list