Change in vdsm[master]: Migration warning due to high guest memory changes

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue Mar 5 06:45:58 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Migration warning due to high guest memory changes
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 413:                 self._vm._dom.abortJob()
Line 414:                 self.stop()
Line 415:                 break
Line 416: 
Line 417:             if dataRemaining > smallest_dataRemaining:
you could just use the 'else' statement here because it can represent the same condition. 
Maybe you could also suggest increase the migration downtime on high memory write.
Line 418:                 self._vm.log.warn(
Line 419:                     'Migration is being delayed'
Line 420:                     ' due to large changes in guest memory.')
Line 421: 


--
To view, visit http://gerrit.ovirt.org/12557
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e7c5a2b7e9e97f047fa893a47408a659a40beb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list