Change in vdsm[master]: Fix checking bonding options for missing bonds.

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue Mar 5 02:55:54 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Fix checking bonding options for missing bonds.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 739:                                              'valid bonding option' % key)
Line 740:         except ValueError:
Line 741:             raise ConfigNetworkError(ne.ERR_BAD_BONDING, 'Error parsing '
Line 742:                                      'bonding options: %r' % bondingOptions)
Line 743: 
I prefer to add a static options list in vdsm code. The benefit of it is simple and the ability of further validation. For one bonding mode, not all keys under '/sys/class/net/bondX/bonding/' are valid.  So we can divide the options by bonding mode. How do you like it?
Line 744: 
Line 745: @contextmanager
Line 746: def validationBond(bonding):
Line 747:     bond_created = False


--
To view, visit http://gerrit.ovirt.org/12701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I023a5bb8a52719559bb9d4716f25e0cba8b3530b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list