Change in vdsm[master]: vdsm: Ignore after_vm_cont hook if _dom was not yet created

danken at redhat.com danken at redhat.com
Sun Mar 3 07:55:13 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Ignore after_vm_cont hook if _dom was not yet created
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

I believe that you are correct: this race has existed since ever, and was tickled by the recent libvirt loop refactoring.

Instead of copying the hack of http://gerrit.ovirt.org/6901 , we should probably wait here on an an event that would be set when the dom object is ready.

--
To view, visit http://gerrit.ovirt.org/12558
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e36f988c965b51855861f04bcebee5ad51d3b09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list