Change in vdsm[master]: vdsm: LibvirtVm._cleanup redundant call removed

danken at redhat.com danken at redhat.com
Sun Mar 3 07:45:18 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Is it really redundant? Any idea what was its motivation? Better ask Igor ;-)

I suspect that it causes a bug or two, and we should consider backporting (if we care for unplug). Either way, considerable verification is due.

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list