Change in vdsm[master]: vdsm: Try to reconnect on vmchannel after timeout

danken at redhat.com danken at redhat.com
Fri Mar 1 10:16:44 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Try to reconnect on vmchannel after timeout
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/guestIF.py
Line 272:         if self.guestStatus not in ("Powered down", "RebootInProgress"):
Line 273:             self.log.log(logging.TRACE, "Guest connection timed out")
Line 274:             self.guestStatus = None
Line 275:             self.log.debug("Attempting to reconnect to channel after timeout")
Line 276:             self._connect()
I did not look deeply into it, but are you sure that calling _connect() within the context of this callback is fine? Isn't there a chance of bottomless recursion?
Line 277: 
Line 278:     def _clearReadBuffer(self):
Line 279:         self._buffer = []
Line 280:         self._bufferSize = 0


--
To view, visit http://gerrit.ovirt.org/11977
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b9418e39558d45c97e9545bc9ecc4935f004e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list