Change in vdsm[master]: clientIF: automatically unpause vms in EIO when SD becomes a...

ahadas at redhat.com ahadas at redhat.com
Sun Jun 30 12:48:48 UTC 2013


Arik Hadas has posted comments on this change.

Change subject: clientIF: automatically unpause vms in EIO when SD becomes active
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/clientIF.py
Line 118:                 try:
Line 119:                     if vm.isVdsmImage(drive):
Line 120:                         self.domainVmIds[drive['domainID']].add(vmId)
Line 121:                 except TypeError:
Line 122:                     pass  # drive is not a dictionary
if 'drive' is not a dictionary we'll get an exception even before the try block, at line 117 right? if so, it needs to be checked before
Line 123:                 except KeyError:
Line 124:                     self.domainVmIds[drive['domainID']] = set([vmId])
Line 125: 
Line 126:     def contEIOVms(self, sdUUID, isValid):


Line 122:                     pass  # drive is not a dictionary
Line 123:                 except KeyError:
Line 124:                     self.domainVmIds[drive['domainID']] = set([vmId])
Line 125: 
Line 126:     def contEIOVms(self, sdUUID, isValid):
how about rename isValid to isDomainConnected, so that it will be more informative?
Line 127:         # This method is called everytime the onDomainConnectivityStateChange
Line 128:         # event is emitted, this event is emitted even when a domain goes
Line 129:         # INVALID if this happens there is nothing to do
Line 130:         if not isValid:


-- 
To view, visit http://gerrit.ovirt.org/16244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f88ebcab07dea20a0288f6b75c5888a74d9e440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list