Change in vdsm[master]: volume: add the BLOCK_SIZE constant

ykaplan at redhat.com ykaplan at redhat.com
Sun Jun 30 08:54:18 UTC 2013


Yeela Kaplan has posted comments on this change.

Change subject: volume: add the BLOCK_SIZE constant
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/volume.py
Line 95: # At the moment this is static and it has been introduced to group all the
Line 96: # previous implicit references to the block size in FileVolume. In the future
Line 97: # it will depend on the storage domain.
Line 98: BLOCK_SIZE = 512
Line 99: 
This is an important unifying of the block size constant and from what I see this size is used explicitly in blockSD, fileUtils and storage mailbox and also implicitly in image as the default block size. 

Why not unify this now into a storage constant?
Line 100: 
Line 101: def fmt2str(format):
Line 102:     return FMT2STR[format]
Line 103: 


-- 
To view, visit http://gerrit.ovirt.org/14589
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia517ec858fb0d7ee45323b7e2a3584c0858222f0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list