Change in vdsm[master]: Fixing spec file for python-ethtool requirements

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Jun 28 06:16:45 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: Fixing spec file for python-ethtool requirements
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm.spec.in
Line 80: BuildRequires: pyflakes
Line 81: BuildRequires: python-pep8
Line 82: BuildRequires: python-ethtool >= 0.8
Line 83: %else
Line 84: BuildRequires: python-ethtool
Well the change required has been back-ported to RHEL6 however I can add the requirement there as well. It would make sense if someone is not updating their environment.
Line 85: %endif
Line 86: 
Line 87: %if 0%{?with_systemd}
Line 88: BuildRequires: systemd-units


Line 163: Requires: python-ethtool >= 0.8-1
Line 164: %if 0%{?fedora} >= 18
Line 165: Requires: initscripts >= 9.42.2-1
Line 166: %endif
Line 167: Requires: python-ethtool >= 0.8
you're right, I haven't noticed that one.
Line 168: Requires: iscsi-initiator-utils >= 6.2.0.872-14
Line 169: Requires: device-mapper-multipath >= 0.4.9-18
Line 170: Requires: e2fsprogs >= 1.41.14
Line 171: Requires: kernel >= 3.6


-- 
To view, visit http://gerrit.ovirt.org/16209
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idafb1dd8861b5049a74de8f295fb8631fbdd4fd9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>


More information about the vdsm-patches mailing list