Change in vdsm[master]: vdsmd.init: Add init adapter

Alon Bar-Lev alonbl at redhat.com
Thu Jun 27 19:20:20 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: vdsmd.init: Add init adapter
......................................................................


Patch Set 2: (2 inline comments)

NICE!!!! looks much cleaner.

I just think that sysv specific tasks can be moved to init.d out of common, to make common simpler.

....................................................
File vdsm/init/daemonAdapter
Line 52: 
Line 53: def flattenCommaStrList(commaStrList):
Line 54:     '''Translate ["a,b", "c,d"] to ["a", "b", "c", "d"]'''
Line 55:     return reduce(lambda accum, commaStr: accum + commaStr.split(','),
Line 56:                   commaStrList, [])
what's wrong with:

 ret = []
 for k in commaStrList: ret.extend(k.split(','))
Line 57: 
Line 58: 
Line 59: if __name__ == '__main__':
Line 60:     args = getArgs()


....................................................
File vdsm/vdsmd.init.in
Line 52: start() {
Line 53:     test_already_running && return 0
Line 54: 
Line 55:     if ! "@VDSMDIR@/init/run_task.sh" --pre-start --include \
Line 56:         "shutdown_conflicting_srv start_needed_srv" ; then
Now... question... why not perform these two tasks here?
Line 57:         log_failure_msg "$prog: failed to execute initialization tasks"
Line 58:         return 1
Line 59:     fi
Line 60: 


-- 
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list