Change in vdsm[master]: Reimplement hsm.getVolumesList().

abaron at redhat.com abaron at redhat.com
Thu Jun 27 14:37:30 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Reimplement hsm.getVolumesList().
......................................................................


Patch Set 6: (3 inline comments)

Once motivation is clear I'll approve the patch

....................................................
Commit Message
Line 3: AuthorDate: 2013-06-16 14:11:13 +0300
Line 4: Commit:     Eduardo Warszawski <ewarszaw at redhat.com>
Line 5: CommitDate: 2013-06-27 11:06:04 +0300
Line 6: 
Line 7: Reimplement hsm.getVolumesList().
Why?
And if this is the motivation then it should be listed in previous patches as well
Line 8: 
Line 9: It is not pool dependant anymore.
Line 10: 
Line 11: Related to BZ#960952.


Line 5: CommitDate: 2013-06-27 11:06:04 +0300
Line 6: 
Line 7: Reimplement hsm.getVolumesList().
Line 8: 
Line 9: It is not pool dependant anymore.
s/dependant/dependent/
Line 10: 
Line 11: Related to BZ#960952.
Line 12: 
Line 13: Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2


Line 7: Reimplement hsm.getVolumesList().
Line 8: 
Line 9: It is not pool dependant anymore.
Line 10: 
Line 11: Related to BZ#960952.
related how? what is the problem you're solving?
Line 12: 
Line 13: Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2


-- 
To view, visit http://gerrit.ovirt.org/15766
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list