Change in vdsm[master]: vm payload: custom volume labels
danken at redhat.com
danken at redhat.com
Thu Jun 27 12:27:12 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: custom volume labels
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File tests/mkimageTests.py
Line 114: return
Line 115: cmd = ['blkid', '-s', 'LABEL', imgPath]
Line 116: try:
Line 117: (ret, out, err) = storage.misc.execCmd(cmd, raw=True)
Line 118: except OSError as e:
"as e" is not really needed.
Line 119: raise SkipTest("cannot execute blkid")
Line 120:
Line 121: self.assertEqual(ret, 0)
Line 122: partitions = out.rpartition('LABEL=')
--
To view, visit http://gerrit.ovirt.org/14347
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5247d8f4ee01c0c871912a7998bdf958fc71ddd1
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list