Change in vdsm[master]: Fix multiple default gateways reporting

danken at redhat.com danken at redhat.com
Wed Jun 26 12:48:08 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Fix multiple default gateways reporting
......................................................................


Patch Set 6: Looks good to me, approved

(1 inline comment)

....................................................
File lib/vdsm/ipwrapper.py
Line 49:         self.device = device
Line 50:         self.table = table
Line 51: 
Line 52:     @classmethod
Line 53:     def parse(cls, text):
this shouldn't really be a public method, but /me too tired of this patchset.
Line 54:         """
Line 55:         Returns a dictionary populated with the route attributes found in the
Line 56:         textual representation.
Line 57:         """


-- 
To view, visit http://gerrit.ovirt.org/15890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd6328a938b955a63bbc0d5c0fb9bfcc7de6d44
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list