Change in vdsm[master]: Fix bridgeless net regression

danken at redhat.com danken at redhat.com
Wed Jun 26 11:39:03 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix bridgeless net regression
......................................................................


Fix bridgeless net regression

The commit:
Ie8bb5fd9fc6ad69cf120d62264d73490b65b82d7
http://gerrit.ovirt.org/#/c/11356/4/

That commit introduced a bug that prevents the user from configuring
a bridgeless network with dhcp. That is so because after the change,
if ipaddr is None, which is the most usual case when configuring a
network for dhcp, bootproto will be overriden by what was on the
original config file (quite probably None).

Change-Id: I2881791f7b2b23cdcea25b73d3eb44de2d2addc8
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/16086
Reviewed-by: Mark Wu <wudxw at linux.vnet.ibm.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/netconf/ifcfg.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Mark Wu: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16086
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2881791f7b2b23cdcea25b73d3eb44de2d2addc8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list