Change in vdsm[master]: Fix the charset conversion logic in hooks.py

msivak at redhat.com msivak at redhat.com
Wed Jun 26 11:28:54 UTC 2013


Martin Sivák has posted comments on this change.

Change subject: Fix the charset conversion logic in hooks.py
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/hooks.py
Line 59:         os.write(xmlfd, domxml or '')
Line 60:         os.close(xmlfd)
Line 61: 
Line 62:         scriptenv = os.environ.copy()
Line 63:         scriptenv.update(vmconf.get('custom', {}))
I think it will cause issues anyway, because if we are really resetting the LC_ALL variable to C we should not use any unicode in the script's environment at all...
Line 64:         if len(params) > 0:
Line 65:             scriptenv.update(params)
Line 66:         if vmconf.get('vmId'):
Line 67:             scriptenv['vmId'] = vmconf.get('vmId')


-- 
To view, visit http://gerrit.ovirt.org/15856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9063291f8a4a392b2913220fe2839386dcffd825
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>


More information about the vdsm-patches mailing list