Change in vdsm[master]: alignmentScanTests: Remove text output validation of help

ykaplan at redhat.com ykaplan at redhat.com
Wed Jun 26 10:01:52 UTC 2013


Yeela Kaplan has uploaded a new change for review.

Change subject: alignmentScanTests: Remove text output validation of help
......................................................................

alignmentScanTests: Remove text output validation of help

'virt-alignment-scan --help' output has changed in fedora 19.
No need to check the actual output text, but only that we
can run 'help'.

Change-Id: I68c64fa6ce39b61d867fd01cbdcb6c31b4ce0435
Signed-off-by: Yeela Kaplan <ykaplan at redhat.com>
---
M tests/alignmentScanTests.py
1 file changed, 1 insertion(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/16098/1

diff --git a/tests/alignmentScanTests.py b/tests/alignmentScanTests.py
index ba0097a..a2be246 100644
--- a/tests/alignmentScanTests.py
+++ b/tests/alignmentScanTests.py
@@ -21,7 +21,7 @@
 
 import os
 import tempfile
-from nose.tools import eq_, raises, assert_not_equals
+from nose.tools import eq_, raises
 from nose.plugins.skip import SkipTest
 from testrunner import VdsmTestCase as TestCaseBase
 from testValidation import slowtest
@@ -50,14 +50,6 @@
         retcode, out, err = runScanArgs("--help")
         eq_(retcode, 0)
         eq_(err, [])
-        out = "\n".join(out)
-        assert_not_equals(
-            out.find("/usr/bin/virt-alignment-scan: check "
-                     "alignment of virtual machine partitions"), -1)
-        assert_not_equals(out.find("Usage:"), -1)
-        assert_not_equals(out.find("Options:"), -1)
-        assert_not_equals(out.find("-a|--add image       Add image"), -1)
-        assert_not_equals(out.find("--help"), -1)
 
     @raises(VirtAlignError)
     def test_bad_path(self):


-- 
To view, visit http://gerrit.ovirt.org/16098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68c64fa6ce39b61d867fd01cbdcb6c31b4ce0435
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list