Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...

gvallare at redhat.com gvallare at redhat.com
Wed Jun 26 09:42:29 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: Qos feature: Adds bandwidth definition at configuration level.
......................................................................


Patch Set 11: (2 inline comments)

....................................................
File tests/netconfTests.py
Line 72:             else:
Line 73:                 restoredContent = file(fn).read()
Line 74:                 self.assertEqual(content, restoredContent)
Line 75: 
Line 76:     def assertEqualXml(self, a, b):
Done
Line 77:         """
Line 78:         Compare two xml strings for equality.
Line 79:         """
Line 80: 


....................................................
File vdsm/netconf/ifcfg.py
Line 27: import selinux
Line 28: import shutil
Line 29: import threading
Line 30: 
Line 31: 
Done
Line 32: from neterrors import ConfigNetworkError
Line 33: import libvirtCfg
Line 34: from storage.misc import execCmd
Line 35: from vdsm import constants


-- 
To view, visit http://gerrit.ovirt.org/15724
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list