Change in vdsm[master]: Multiple Gateways[2/2]: configNetwork integration

danken at redhat.com danken at redhat.com
Wed Jun 26 07:44:38 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Multiple Gateways[2/2]: configNetwork integration
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File vdsm/sourceRoute.sh
Line 1: #!/bin/bash
Line 2: 
Line 3: sourceRoute_config() {
Line 4:     python /usr/share/vdsm/sourceRoute.pyc "configure" "dhcp" $new_ip_address $new_subnet_mask $new_routers $interface
for me, long lines are much harder to review
Line 5: }
Line 6: 
Line 7: sourceRoute_restore() {
Line 8:     python /usr/share/vdsm/sourceRoute.pyc "remove" "dhcp" $interface


-- 
To view, visit http://gerrit.ovirt.org/15528
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4415c6ec91ac49c56703d59b99d3a21b328015b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list