Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

asegurap at redhat.com asegurap at redhat.com
Tue Jun 25 15:33:08 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Multiple Gateways[1/2]: add sourceRouting module
......................................................................


Patch Set 22: (1 inline comment)

....................................................
File vdsm/sourceRoute.py
Line 97:                 route = Route.fromText(entry)
Line 98:                 route.table = table
Line 99:                 if route.device == device:
Line 100:                     routes.append(route)
Line 101:             except ValueError:
This try catch is because routeShowTable gives broadcast and local tables that are rejected by from text for not being the kind of routes we work with. The rejection is in form of exception.

Consider this a kind of filtering.
Line 102:                 pass
Line 103: 
Line 104:         return routes
Line 105: 


-- 
To view, visit http://gerrit.ovirt.org/15207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0224d896724b9cdc44215e92f0da0be71fd19038
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list