Change in vdsm[master]: net_functional_tests: bondWithManyVlans.
wudxw at linux.vnet.ibm.com
wudxw at linux.vnet.ibm.com
Tue Jun 25 06:14:05 UTC 2013
Mark Wu has posted comments on this change.
Change subject: net_functional_tests: bondWithManyVlans.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/functional/utils.py
Line 154: return result['status']['code'], result['status']['message']
Line 155:
Line 156: def networkExists(self, network_name, bridged=None, info=None):
Line 157: if info is None:
Line 158: info = netinfo.NetInfo(self.vdscli.getVdsCapabilities()['info'])
Any reason not replacing this line of code with the new wrapper function getNetInfo() ?
Same problems in bondExists, vlanExixts. But if you choose to keep netinfo in vdsproxy, then you don't need call it again.
Line 159: return network_name in info.networks and \
Line 160: (bridged is None or info.networks[network_name]['bridged'] ==
Line 161: bridged)
Line 162:
--
To view, visit http://gerrit.ovirt.org/16025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9da7bd407cfbd9acab5e20384bff1254c26ffc5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list