Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

amuller at redhat.com amuller at redhat.com
Mon Jun 24 13:36:24 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Multiple Gateways[1/2]: add sourceRouting module
......................................................................


Patch Set 19: (1 inline comment)

....................................................
File vdsm/sourceRoute.py
Line 136:             rules = self._getRules(network)
Line 137:             if rules:
Line 138:                 table = self._getTable(rules)
Line 139:                 if table:
Line 140:                     self.rules = rules
This was originally so that a SourceRoute object could be passed along to the configurator, with its routes and rules set. Now the routes and rules are passed themselves, so there's no need to save the routes and rules in the SourceRoute class itself.
Line 141:                     self.routes = self._getRoutes(table)
Line 142:                     self.configurator.removeSourceRoute(self.routes,
Line 143:                                                         self.rules,
Line 144:                                                         self.device)


-- 
To view, visit http://gerrit.ovirt.org/15207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0224d896724b9cdc44215e92f0da0be71fd19038
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list